autotests fixes

Signed-off-by: galeon <dertiellis@gmail.com>

modloaderversionservice.cpp

@@ -244,6 +244,7 @@ void ModLoaderVersionService::startRefresh(ModLoader loader, const QString &game
     {
         int outstanding = 2;
         QHash<QString, QList<LoaderVersionEntry>> merged;
+        QHash<QString, QList<LoaderVersionEntry>> legacy;
         QHash<QString, QString> recommended;
         bool primaryOk = false;
         QString warning;
@@ -258,6 +259,8 @@ void ModLoaderVersionService::startRefresh(ModLoader loader, const QString &game
             return;
         }
 
+        for (auto it = state->legacy.cbegin(); it != state->legacy.cend(); ++it)
+            state->merged[it.key()] += it.value();
         for (auto it = state->merged.begin(); it != state->merged.end(); ++it) {
             const QString promoted = state->recommended.value(it.key());
             if (promoted.isEmpty())
@@ -317,10 +320,8 @@ void ModLoaderVersionService::startRefresh(ModLoader loader, const QString &game
         connect(legacy, &QNetworkReply::finished, this, [legacy, state, settle] {
             legacy->deleteLater();
             if (legacy->error() == QNetworkReply::NoError) {
-                const auto extra = parseMavenMetadata(legacy->readAll(), ModLoader::NeoForge,
-                                                      /*legacyNeoForge=*/true);
-                for (auto it = extra.constBegin(); it != extra.constEnd(); ++it)
-                    state->merged[it.key()] += it.value();
+                state->legacy = parseMavenMetadata(legacy->readAll(), ModLoader::NeoForge,
+                                                   /*legacyNeoForge=*/true);
             }
             settle();
         });